Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cra-kitchen-sink versioning for alpha release #1400

Merged
merged 2 commits into from
Jul 3, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 2, 2017

Issue: N/A

What I did

-alpha naming scheme is not semver, so Lerna does not do the right
thing here, and as a workaround we need to hardcode the version numbers
while we’re doing alpha releases if we want our example apps to work
properly.

How to test

yarn bootstrap
cd examples/cra-kitchen-sink
yarn storybook

Before this PR, you will get an error because it is using the public NPM version of addon-notes.

After this PR, you'll be using the repo version of addon-notes, and the example should work.

`-alpha` naming scheme is not semver, so Learn does not do the right
thing here, and as a workaround we need to hardcode the version numbers
while we’re doing alpha releases if we want our example apps to work
properly.
@storybookbot
Copy link
Collaborator

storybookbot commented Jul 2, 2017

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jul 2, 2017

Codecov Report

Merging #1400 into release/3.2 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.2    #1400   +/-   ##
============================================
  Coverage        15.82%   15.82%           
============================================
  Files              237      237           
  Lines             5043     5043           
  Branches           726      695   -31     
============================================
  Hits               798      798           
- Misses            3648     3669   +21     
+ Partials           597      576   -21
Impacted Files Coverage Δ
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/notes/src/react.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5642b7d...90e9780. Read the comment docs.

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jul 2, 2017
@shilman shilman merged commit a2802e5 into release/3.2 Jul 3, 2017
@Hypnosphi Hypnosphi deleted the examples-3.2-alpha-versioning branch August 17, 2017 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants