Addon-Docs: Do not create extra Vue instance for Dynamic source rendering #14002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocka
commented
Feb 22, 2021
pocka
commented
Feb 22, 2021
phated
approved these changes
Feb 22, 2021
|
Unsure why the e2e-tests-yarn-2-pnp are still failing 🤔 |
This commit changes how the decorator grab Vue.js' VNode tree. Previously it creates a new Vue instance and traverse the tree. But this causes a lot of problems such as unexpected mount call and DOM-detached instance. I removed the instruction then added a decorator that do the instruction from inside of an existing VNode tree.
pocka
force-pushed
the
pocka/feat/dynamic-source-rendering-use-render-tree
branch
from
a15f433
to
85f2a43
Compare
|
CI has been failing for some time span (?). I |
shilman
changed the title
shilman
deleted the
pocka/feat/dynamic-source-rendering-use-render-tree
branch
This was referenced Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13633 (already closed though)
Reduce the amount of the work for #13862
Probably related to #13697 and #13721 (hopefully this patch will fix them)
What I did
Removed
new Vuein source decorator, Added decorator component that renders story source code based on VNode.How to test
If your answer is yes to any of these, please make sure to include it in your PR.