Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix toolbar text using theme color #14308

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Conversation

rev3rsor
Copy link
Contributor

@rev3rsor rev3rsor commented Mar 22, 2021

Issue: #14664

Toolbar buttons don't use barTextColor from theme

What I did

Change defaulted text color to theme variable

How to test

Does this need a new example in the kitchen sink apps?

  • To test, set barTextColor in theme.create() e.g.
// examples/cra-kitchen-sink/.storybook/manager.js

addons.setConfig({
  ...
  theme: create({
    base: 'light',
    barTextColor: 'green', // <--
    brandTitle: 'CRA Kitchen Sink',
    brandUrl: 'https://github.com/storybookjs/storybook/tree/master/examples/cra-kitchen-sink',
    gridCellSize: 12,
  }),
});

Pre-fix: color only applies to icon buttons
Post-fix: unselected button text should be the same color as well

@shilman shilman changed the title Fix toolbar text using theme color UI: Fix toolbar text using theme color Mar 23, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @rev3rsor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants