Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli-options.md #14418

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Update cli-options.md #14418

merged 2 commits into from
Apr 1, 2021

Conversation

hydrosquall
Copy link
Contributor

Fixes typo in build-storybook --debug-webpack documentation (start-storybook mentioned in the build-storybook section)

Fix typo in `build-storybook --debug-webpack` documentation
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hydrosquall thank you once again for the time and effort you've put into the pull request. Only one small change I need you to take care of and we're good to go!

Let me know once you've managed to address this and we'll gladly merge the pull request!

Stay safe

@@ -55,7 +55,7 @@ Usage: build-storybook [options]
| --quiet | Suppress verbose build output | `build-storybook --quiet` |
| --no-dll | Do not use dll reference (no-op) | `build-storybook --no-dll` |
| --debug-webpack | Display final webpack configurations for debugging purposes | `build-storybook --debug-webpack` |
| `--webpack-stats-json <directory>` | Write Webpack Stats JSON to disk | `start-storybook --webpack-stats-json /tmp/webpack-stats` |
| `--webpack-stats-json <directory>` | Write Webpack Stats JSON to disk | `build-storybook --webpack-stats-json /tmp/webpack-stats` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hydrosquall if you could adjust the folder to something more like /my-storybook/webpack-stats we'd appreciate it. I might be overthinking this, but the change will prevent confusion regarding the tmp folder with Unix.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 31, 2021
@jonniebigodes jonniebigodes self-assigned this Mar 31, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @hydrosquall !

@shilman shilman merged commit 60c2a4f into storybookjs:next Apr 1, 2021
@hydrosquall hydrosquall deleted the patch-1 branch April 1, 2021 23:53
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants