-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli-options.md #14418
Update cli-options.md #14418
Conversation
Fix typo in `build-storybook --debug-webpack` documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hydrosquall thank you once again for the time and effort you've put into the pull request. Only one small change I need you to take care of and we're good to go!
Let me know once you've managed to address this and we'll gladly merge the pull request!
Stay safe
docs/api/cli-options.md
Outdated
@@ -55,7 +55,7 @@ Usage: build-storybook [options] | |||
| --quiet | Suppress verbose build output | `build-storybook --quiet` | | |||
| --no-dll | Do not use dll reference (no-op) | `build-storybook --no-dll` | | |||
| --debug-webpack | Display final webpack configurations for debugging purposes | `build-storybook --debug-webpack` | | |||
| `--webpack-stats-json <directory>` | Write Webpack Stats JSON to disk | `start-storybook --webpack-stats-json /tmp/webpack-stats` | | |||
| `--webpack-stats-json <directory>` | Write Webpack Stats JSON to disk | `build-storybook --webpack-stats-json /tmp/webpack-stats` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hydrosquall if you could adjust the folder to something more like /my-storybook/webpack-stats
we'd appreciate it. I might be overthinking this, but the change will prevent confusion regarding the tmp folder with Unix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks @hydrosquall !
Fixes typo in
build-storybook --debug-webpack
documentation (start-storybook mentioned in the build-storybook section)