Lit: Initial lit2 support #14600
Merged
Lit: Initial lit2 support #14600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
changed the title
…vor of addon control
`babel-loader` is required in the context of `builder-webpack4` so there is no no need to have it as a dep.
|
@gaetanmaisse these last set of changes (addon-docs/babel-loader stuff) look good, but probably should be in their own PR! |
|
Yep @shilman, I will open a PR with these and maybe some other related stuff ;) |
The goal is to avoid adding dependencies related to the example in the SB codebase workpaces. Considering this example as a stand-alone workspace make it works in a more realistic way. Working on things in `@storybook/lit` and want to test them in lit-kitchen-sink? Run: - `yarn build lit --watch` in the monorepo root folder - `yarn install` then `yarn storybook` in lit-kitchen-sink folder You're good to go, both changes in the example code or in `@storybook/lit` will be reflected in the UI.
shilman
reviewed
Apr 18, 2021
| @@ -3,3 +3,5 @@ | |||
| This example directory represents the application you wish to integrate storybook into. | |||
|
|
|||
| Run `yarn install` to sync Storybook module with the source code and run `yarn storybook` to start the Storybook. | |||
|
|
|||
| When developing things in `@storybook/lit` you can run `yarn build lit --watch` in the root folder of the monorepo and both changes in the example code or in `@storybook/lit` will be reflected in the UI. | |||
… is providing it" This reverts commit a652a01 as it needs some extra work that should be done in a separated PR
This was referenced Apr 28, 2021
Nx Cloud ReportCI ran the following commands for commit 3cc3da4. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
…command for now As `lit-kitchen-sink` is not part of the monorepo it requires some extra work to make it build properly as we need to install deps first.
|
@gaetanmaisse Looks good to me. |
shilman
changed the title
shilman
approved these changes
May 10, 2021
shilman
added
the
run e2e extended test suite
4 tasks
merceyz
reviewed
May 10, 2021
| @@ -0,0 +1,9 @@ | |||
| enableGlobalCache: true | |||
There was a problem hiding this comment.
Configs are inherited from the parent recursively so you probably don't need this config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14455
What I did
Initial start to setting up lit framework