Examples: Move from placehold.it to place-hold.it for mock images #14637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterpeterparker
requested review from
aaronmcadam,
ndelangen,
shilman,
tmeasday and
usulpro
as code owners
shilman
approved these changes
Apr 17, 2021
shilman
added
maintenance
shilman
changed the title
|
Coolio. My pleasure 😃 |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 23, 2021
Examples: Move from placehold.it to place-hold.it for mock images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
It looks like a dash is missing in the
place-hold.iturls.Is for example
https://placehold.it/350x150(does not generate any image placeholder):Should be
https://place-hold.it/350x150(which does generate the following image):How to test
I tested manually I have to say. I ran a search a replace to fix the typo.