Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs: fix label alignment #1471

Merged
merged 2 commits into from
Jul 15, 2017
Merged

Knobs: fix label alignment #1471

merged 2 commits into from
Jul 15, 2017

Conversation

Hypnosphi
Copy link
Member

Issue:
#1086 introduced increased font size for labels. Unfortunately, that broke alignment

What I did

Lowered the padding-top

How to test

Run any story with knobs addon

Before:
screen shot 2017-07-14 at 20 36 52
After:
screen shot 2017-07-14 at 20 37 09

#1086 introduced increased font size for labels. Unfortunately, that broke alignment. This PR fixes it
@codecov
Copy link

codecov bot commented Jul 14, 2017

Codecov Report

Merging #1471 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   14.34%   14.34%           
=======================================
  Files         201      201           
  Lines        4614     4614           
  Branches      503      497    -6     
=======================================
  Hits          662      662           
  Misses       3527     3527           
  Partials      425      425
Impacted Files Coverage Δ
addons/knobs/src/components/types/Number.js 8.06% <ø> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-start.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/info/src/components/Node.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 41.66% <0%> (ø) ⬆️
addons/knobs/src/components/WrapStory.js 12% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 28.57% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76bfb0...7b96b05. Read the comment docs.

To match that of a one-line TextType textarea
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hypnosphi looks great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants