Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use arg-parser defaults #14857

Merged
merged 1 commit into from May 8, 2021
Merged

CLI: Use arg-parser defaults #14857

merged 1 commit into from May 8, 2021

Conversation

jamesgeorge007
Copy link
Member

What I did

This PR aims at removing extraneous code.

Motivation

From v5.0.0, Commander.js displays help information for missing subcommand by default.

How to test

Invoke the sb binary without any arguments; help information shows up as expected.

@jamesgeorge007 jamesgeorge007 added maintenance User-facing maintenance tasks cli labels May 8, 2021
@nx-cloud
Copy link

nx-cloud bot commented May 8, 2021

Nx Cloud Report

CI ran the following commands for commit d618092. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jamesgeorge007 💯 !!

@shilman shilman changed the title CLI: rely on arg-parser defaults CLI: Use arg-parser defaults May 8, 2021
@shilman shilman merged commit 0d9022c into next May 8, 2021
@shilman shilman deleted the arg-parser-defaults branch May 8, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants