Extract addon-knobs from monorepo #14874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alexandrebodin,
alterx,
igor-dv,
leonrodenburg,
ndelangen,
stijnkoopal,
theinterned,
tmeasday and
usulpro
as code owners
Nx Cloud ReportCI ran the following commands for commit 5d0d8a3. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit ddcb3bd. Check the Getting started section to configure the app. Sent with 💌 from NxCloud. |
ndelangen
approved these changes
May 10, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14831
What I did
Extract addon-knobs into its own repo: https://github.com/storybookjs/addon-knobs
How to test
yarn build && yarn storybookwork in new repo?