Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (Docs) Minor polish to the decorators docs #14907

Merged
merged 1 commit into from May 13, 2021

Conversation

jonniebigodes
Copy link
Contributor

With this small pull request, the writing-stories/decorators function was updated and polished a bit to address and close #13927.

What was done:

  • Polished the documentation.
  • Included the missing items available to the decorators context.

Merge this after #14893 to prevent issues with the build.

Feel free to provide feedback

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 12, 2021
@nx-cloud
Copy link

nx-cloud bot commented May 12, 2021

Nx Cloud Report

CI ran the following commands for commit 7b469ab. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 8012514 into next May 13, 2021
@shilman shilman deleted the chore_writing_stories_decorators_polish branch May 13, 2021 04:41
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 25, 2021
shilman added a commit that referenced this pull request May 25, 2021
…rators_polish

Chore: (Docs) Minor polish to the decorators docs
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom styles for components based on view mode
2 participants