Undo channel stubbing - causes NPM version errors to fail silently

[shilman]

Issue: #1486

What I did

Undo bad changes in PR

How to test

CI tests

(Or force a messed up NPM version error... has bitten many of us, but not sure the best way to repro)

[shilman]

Got @ndelangen 's approval over slack 🍷

[tmeasday]

Perhaps we should replace it with functions that throw useful errors to help people debug?

function debugChannelError() {
  throw new Error('Tried to access non-existant addons channel, see #1234 for details');
}

this.channel = { on: debugChannelError, emit: debugChannelError }

[codecov]

Codecov Report

Merging #1494 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1494      +/-   ##
=========================================
- Coverage   14.61%   14.6%   -0.01%     
=========================================
  Files         202     202              
  Lines        4653    4655       +2     
  Branches      505     509       +4     
=========================================
  Hits          680     680              
+ Misses       3545    3535      -10     
- Partials      428     440      +12

Impacted Files	Coverage Δ
lib/addons/src/index.js	0% <0%> (ø)	⬆️
...rc/modules/ui/components/left_panel/text_filter.js	33.33% <0%> (ø)	⬆️
...react-native/src/manager/components/PreviewHelp.js	0% <0%> (ø)	⬆️
lib/ui/src/libs/key_events.js	23.25% <0%> (ø)	⬆️
lib/ui/src/modules/ui/configs/init_panels.js	25% <0%> (ø)	⬆️
...codemod/src/transforms/update-organisation-name.js	40.62% <0%> (ø)	⬆️
.../src/manager/containers/CommentsPanel/dataStore.js	34.78% <0%> (ø)	⬆️
app/react/src/server/build.js	0% <0%> (ø)	⬆️
app/react/src/server/babel_config.js	44.82% <0%> (ø)	⬆️
addons/info/src/components/markdown/code.js	0% <0%> (ø)	⬆️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e1155...ee0e3cb. Read the comment docs.

[shilman]

@tmeasday updated per your suggestion

[tmeasday]

This doesn't seem right: #1374 ?

Maybe we should make a FAQ entry? This doesn't seem like an issue that is going to go away :/

[ndelangen]

Is this mergable @tmeasday ?

[tmeasday]

LGTM!