Build: Improve e2e script #14980
Merged
Build: Improve e2e script #14980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the types are messed up and although yarn thinks version 2.4.0 is latest it is actually 2.0.11
Nx Cloud ReportCI ran the following commands for commit ee559b0. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
yannbf
reviewed
May 19, 2021
| logger.info(`🧮 E2E Results`); | ||
|
|
||
| Object.entries(e2eResult).forEach(([configName, result]) => { | ||
| logger.info(`${configName}: ${result ? 'OK' : 'KO'}`); |
There was a problem hiding this comment.
This is nice! But KO reads very similar to OK, maybe another word would be better?
ndelangen
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How to test
yarn local-registry --port 6000 --open --publishandyarn test:e2e-framework --clean --use-local-sb-cli cra