Fixed regression introduced in #14563. #15005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression prevented Axe tests from being run and instead the default snapshots were being used. This was due to a missing `return` statement that I overlooked in the original source because of the implicit return.
Nx Cloud ReportCI ran the following commands for commit 1bd3938. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Hypnosphi
approved these changes
May 21, 2021
|
Looks like this was already fixed in #15006, closing. Thanks for following up!! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression prevented Axe tests from being run and instead the default snapshots were being used. This was due to a missing
returnstatement that I overlooked in the original source because of the implicit return.Additional context can be found here: https://github.com/storybookjs/storybook/pull/14563/files#r637109923