Documentation: Change isToolshown type from String to Boolean #15377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit d15199c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
apapadopoulou
changed the title
jonniebigodes
added
the
patch:yes
|
@apapadopoulou thanks for catching this and help us with the documentation improvements. Indeed you're correct and it should be a Boolean as opposed to a String value. Merging this. |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jun 29, 2021
…-value-type Documentation: Change isToolshown type from String to Boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: While going through the documentation, I noticed that the
isToolshownapi value is categorized asString, but I think that it should beboolean.What I did
I changed the type of
isToolshownfromStringtoBoolean.How to test
You can view the file preview.
If your answer is yes to any of these, please make sure to include it in your PR.