Add RegExp option for hierarchySeparator #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usulpro
added
addon: options
cleanup
shilman
requested changes
Jul 30, 2017
addons/options/src/preview/index.js
Outdated
| @@ -7,14 +7,26 @@ export function init() { | |||
| // NOTE nothing to do here | |||
| } | |||
|
|
|||
| function regExpStringify(exp) { | |||
| if (!exp) return null; | |||
There was a problem hiding this comment.
if(typeof exp === 'string') return exp;
if(Object.prototype.toString.call(exp) === '[object RegExp]') return exp.source;
return null;
shilman
approved these changes
Jul 30, 2017
Codecov Report
@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
- Coverage 20.53% 20.52% -0.01%
==========================================
Files 241 241
Lines 5220 5222 +2
Branches 644 641 -3
==========================================
Hits 1072 1072
+ Misses 3660 3654 -6
- Partials 488 496 +8
Continue to review full report at Codecov.
|
igor-dv
approved these changes
Jul 30, 2017
| @@ -266,7 +266,7 @@ storiesOf('component.Button', module) | |||
|
|
|||
| // Atomic | |||
|
|
|||
| storiesOf('Cells¯\\_(ツ)_/¯Molecules.Atoms/simple', module) | |||
| storiesOf('Cells/Molecules.Atoms/simple', module) | |||
| const channel = addons.getChannel(); | ||
| if (!channel) { | ||
| throw new Error( | ||
| 'Failed to find addon channel. This may be due to https://github.com/storybooks/storybook/issues/1192.' | ||
| ); | ||
| } | ||
| const options = { | ||
| ...newOptions, | ||
| hierarchySeparator: regExpStringify(newOptions.hierarchySeparator), |
There was a problem hiding this comment.
what will happen if null will be passed here ?
|
so we can merge it if nobody objects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #151
hierarchySeparatoroption allows only a string with RegExpWhat I did
hierarchySeparatorcould take aRegular Expressiondirectly (as well as strings)How to test
run
cra-kitchen-sink