Add checkboxes to pull request template #15799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 149bb74. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
darleendenno
reviewed
Aug 9, 2021
Comment on lines
+7
to
+9
| - [ ] Is this testable with Jest or Chromatic screenshots? | ||
| - [ ] Does this need a new example in the kitchen sink apps? | ||
| - [ ] Does this need an update to the documentation? |
There was a problem hiding this comment.
I like option 1, personally. Thanks for improving the PR template ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Here's an idea:
Rethink a bit on the template so it actually has a checklist rather than a yes/no questionnaire, serving as a good reminder that has to be always checked.
Idea 1 - Something like this example:
Checklist
Idea 2:
Just update the template so there's no need to type yes/no, but click the checks instead.
Do you think this will add more value, or make it more confusing?