Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyshots/vue3: Fix story render with singleton vue app #15983

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

SasanFarrokh
Copy link
Member

@SasanFarrokh SasanFarrokh commented Sep 4, 2021

Issue: #14655

What I did

Use the singleton @storybook/vue3 exported app to render the stories in storyshots

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented Sep 4, 2021

Nx Cloud Report

CI ran the following commands for commit 1ad21fe. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman changed the title fix: vue3 storyshots - use the singleton vue app to render stories Addon-storyshots/vue3: Fix story render with singleton vue app Sep 6, 2021
@shilman shilman changed the title Addon-storyshots/vue3: Fix story render with singleton vue app Storyshots/vue3: Fix story render with singleton vue app Sep 6, 2021
@shilman shilman merged commit ce4fa5d into storybookjs:next Oct 18, 2021
@shilman shilman added this to the 6.4 PRs milestone Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants