New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue: support @values in args table #16019
Vue: support @values in args table #16019
Conversation
Nx Cloud ReportCI ran the following commands for commit ae970f4. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Hi, it seems that there is a conflict. Should i rebase my branch?. |
Yes! Or merge the latest |
2037f25
to
ae970f4
Compare
Hi, thank you for reaching out 🙏. As for the conflicts, I chose to rebase my branch onto |
Thanks a lot for your contribution @adrianpdm! While I was testing this, I found a few things worth mentioning: Regarding point 2, @shilman I believe this might be a bug in controls and not something related to this change. WDYT? |
Thank you for testing this out @yannbf 😃 I surely can filter out the empty values that is caused by the dangling commas. Although, to me it is to be expected since that just how As for the HMR issue, i do experience the same behavior in my company's Storybook (v6.2.9), which doesn't trigger rebuilt when making some docgen-related changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adrianpdm sorry for the long time (I was on vacation) to reply!
I believe we should just keep things as is. The HMR is something not related to this PR anyway, and we should look further into it.
Thanks a lot for your contribution! This one is good to go!
Issue: #13764 Addon-docs/Vue: Support @values in ArgsTable
What I did
Framework
Vue
Changes
addon/docs
ArgTypes
is returned from theextractArgTypes: ArgTypesExtractor
propDef
, ensuring its type is converted toenum
if@values
tag is definedsbType
with mutatedpropDef.type
propDef.type.summary
examples/vue-cli
Button.vue
argTypes.size
from Button's story, ensuring its size options are inferred from the generated docs, rather than being manually defined.How to test
cd examples/vue-cli yarn storybook
Enums defined using
@values
tag will be shown underDescription
and available as eitherradio
orselect
control in theArgsTable
.