Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix loading behavior for Canvas doc block #16161

Merged
merged 1 commit into from Sep 25, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 25, 2021

Issue: #16117

What I did

The canvas doc block needed to be updated to accommodate the story loading state.

How to test

See the official-storybook story from the issue:

http://localhost:9011/official-storybook/?path=/docs/addons-controls--basic

@nx-cloud
Copy link

nx-cloud bot commented Sep 25, 2021

Nx Cloud Report

CI ran the following commands for commit 094089e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit cf2c75b into next Sep 25, 2021
@shilman shilman deleted the 16117-fix-source-state-open branch September 25, 2021 21:50
@shilman shilman added this to the 6.4 PRs milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants