Core: Support composing stories in both v6 and v7 modes #16224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 202cb51. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
tmeasday
approved these changes
Oct 4, 2021
lib/api/src/modules/refs.ts
Outdated
| const index = (stories as unknown) as Record<StoryId, StoryIndexStory>; | ||
| storiesHash = transformStoryIndexToStoriesHash({ v, stories: index }, { provider }); | ||
| } else { | ||
| throw new Error(`Composition: Unknown stories.json version: ${v}`); |
There was a problem hiding this comment.
Hmm, I wonder if we'll regret this if we ever want to make v:4 backwards compatible
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16049
What I did
stories.jsonSTORY_PREPAREDevents for refsHow to test
See attached tests