Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix broken link in react native template #16372

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

AllanChain
Copy link
Contributor

Issue: Link in react native template is broken

What I did

Changed it to new react-native repo

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Oct 16, 2021

Nx Cloud Report

CI ran the following commands for commit c197da3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for the fix! 🙏

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch cli bug and removed documentation labels Oct 16, 2021
@shilman shilman changed the title chore: fix broken link in react native template CLI: Fix broken link in react native template Oct 16, 2021
@shilman shilman merged commit 43bc8cc into storybookjs:next Oct 16, 2021
@shilman shilman added this to the 6.4 PRs milestone Oct 18, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants