Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix missing FEATURES error #16389

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Core: Fix missing FEATURES error #16389

merged 1 commit into from
Oct 18, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 18, 2021

Issue: N/A

What I did

Don't fail if global.FEATURES is undefined (e.g. by storybook-builder-vite)

⚠️ This should also be fixed in storybook-builder-vite! storybookjs/builder-vite#78

self-merging @tmeasday

How to test

N/A

@nx-cloud
Copy link

nx-cloud bot commented Oct 18, 2021

Nx Cloud Report

CI ran the following commands for commit d18d510. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Oct 18, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit d18d510.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@shilman shilman changed the title Fix missing FEATURES global Core: Fix missing FEATURES global Oct 18, 2021
@shilman shilman merged commit 91e6968 into next Oct 18, 2021
@shilman shilman deleted the fix-missing-features branch October 18, 2021 14:18
@shilman shilman changed the title Core: Fix missing FEATURES global Core: Fix missing FEATURES error Oct 18, 2021
@shilman shilman added this to the 6.4 PRs milestone Oct 18, 2021
@joshwooding
Copy link
Contributor

@shilman I think one line was missed in PreviewWeb?

...(!FEATURES.breakingChangesV7 && this.storyStore.getStoryContext(story)),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants