Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Refactor story store to be simpler when getting the index #16397

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Core: Refactor story store to be simpler when getting the index #16397

merged 1 commit into from
Oct 19, 2021

Conversation

tmeasday
Copy link
Member

What I did

Simplified as discussed @shilman

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@tmeasday tmeasday requested a review from shilman October 19, 2021 05:38
@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 4e007aa. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added core maintenance User-facing maintenance tasks labels Oct 19, 2021
shilman
shilman approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! 😍

@shilman shilman changed the title Refactor story store to be a bit simpler when getting the index Core: Refactor story store to be simpler when getting the index Oct 19, 2021
@shilman shilman added this to the 6.4 PRs milestone Oct 19, 2021
@shilman shilman merged commit f2a5519 into next Oct 19, 2021
@shilman shilman deleted the simplify-story-index-generation branch October 19, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmeasday @shilman