-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Rerun loaders when args/globals change #16476
Conversation
Nx Cloud ReportCI ran the following commands for commit 32c4776. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 💯
It looks like after this release, there are some bugs with the URL params. E.g., I have URLs like |
Hey @pahan35 what version of SB is that there and what does the repo look like? Can you post the code somewhere? |
It is a usual repro project from
|
@tmeasday mentioned bug looks fixed in |
Thanks @pahan35 |
Issue: #16260
What I did
renderToDOM
warning to a more sensible placeHow to test