Upgrade from node-sass to sass in examples/angular-cli #16663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Angular example was using an outdated version of node-sass which failed to build on my PC. I fixed this by upgrading to the latest version of sass. I ran the example and verified that the Sass styles were applied.
Nx Cloud ReportCI ran the following commands for commit e09b049. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
added
angular
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Can't run
yarn installin the Storybook repository because of a node-sass build failure. This was on Windows 11 and Node 16. node-sass-build-failure.logWhat I did
The Angular example was using an outdated version of node-sass which failed to build on my PC. I fixed this by upgrading to the latest version of sass. I ran the example and verified that the Sass styles were applied.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.