Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve sb repro directory prompt #16854

Merged
merged 1 commit into from Dec 1, 2021
Merged

CLI: Improve sb repro directory prompt #16854

merged 1 commit into from Dec 1, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 1, 2021

Issue: N/A

What I did

The repro command will set the template of choice as default directory name, so you can just press enter:
image

If you set a directory name manually and that directory exists, rather than failing the entire command, it will show a validation message until you type a directory that wouldn't clash:
image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the cli label Dec 1, 2021
@yannbf yannbf self-assigned this Dec 1, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2021

Nx Cloud Report

CI ran the following commands for commit e9f9ac5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@yannbf yannbf requested a review from shilman December 1, 2021 12:50
@shilman shilman changed the title fix(repro): improve directory prompt CLI: Improve sb repro directory prompt Dec 1, 2021
@shilman shilman added the maintenance User-facing maintenance tasks label Dec 1, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @yannbf !!! ❤️

@shilman shilman merged commit 4b49d99 into next Dec 1, 2021
@shilman shilman deleted the fix/cli-repro branch December 1, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants