Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We missed this as part of #1515 #1705

Merged
merged 2 commits into from
Aug 22, 2017
Merged

We missed this as part of #1515 #1705

merged 2 commits into from
Aug 22, 2017

Conversation

tmeasday
Copy link
Member

We need to check for the channel exception on both sides of the channel.

Issue:

Our RN examples were broken on master (I guess RN was broken in general).

What I did

@ndelangen's change to check the channel on the manager side.

How to test

# clean properly
npm i && npm run bootstrap && npm run build-packs && npm run bootstrap:react-native-vanilla
cd examples/react-native-vanilla
npm run storybook
# check no exception in browser

react-native run ios
# check works

We need to check for the channel exception on both sides of the channel.
@codecov
Copy link

codecov bot commented Aug 22, 2017

Codecov Report

Merging #1705 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   21.22%   21.21%   -0.01%     
==========================================
  Files         252      252              
  Lines        5706     5708       +2     
  Branches      695      687       -8     
==========================================
  Hits         1211     1211              
- Misses       3964     3983      +19     
+ Partials      531      514      -17
Impacted Files Coverage Δ
app/react-native/src/manager/provider.js 0% <0%> (ø) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
app/react/src/server/utils.js 0% <0%> (-32.15%) ⬇️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/info/src/components/Node.js 38.88% <0%> (ø) ⬆️
addons/info/src/components/PropTable.js 20.16% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c843886...fd48cbe. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆🔫

@shilman shilman merged commit 92ec2d6 into master Aug 22, 2017
@shilman shilman deleted the fix-broken-rn-channel branch August 22, 2017 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks react-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants