Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-syntax-highlighter to pick up security patch upstream in highlight.js #17100

Merged

Conversation

lucasgonze
Copy link
Contributor

Signed-off-by: Lucas Gonze lucas@gonze.com

Issue:

What I did

Upgraded package to pick up a security patch. Note that I disclosed the details via Twitter DM. Also, this needs to be back-ported to the 5.3.x branch.

Ran yarn run test. Found no new test failures compared with the count in the next branch.

How to test

  • [ This has no new functionality that would require a test. ] Is this testable with Jest or Chromatic screenshots?
  • [ No ] Does this need a new example in the kitchen sink apps?
  • [ No ] Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

…n highlight.js

Signed-off-by: Lucas Gonze <lucas@gonze.com>
@nx-cloud
Copy link

nx-cloud bot commented Dec 30, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 3ba8982. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

package.json Outdated Show resolved Hide resolved
@lucasgonze lucasgonze force-pushed the chore-upgrade-react-syntax-highlighter branch from df835e3 to 0a93427 Compare January 3, 2022 23:20
@lucasgonze
Copy link
Contributor Author

I have done yarn remove yarn.lock, rebased on current next, and re-run tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants