Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Apply Docs mode to composed storybooks #17292

Merged
merged 2 commits into from Feb 4, 2022

Conversation

frassinier
Copy link
Contributor

Issue: #17291

What I did

If refs change in the Manager's sidebar, and you're in Docs mode (--docs), then adapt our tree

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 76ad114. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@frassinier
Copy link
Contributor Author

Can be related to #15597

@frassinier
Copy link
Contributor Author

Ping @ghengeveld or @shilman
Easy review here! 👋🏻

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @frassinier 💯

@shilman shilman changed the title Core: Composition in Docs mode Core: Apply Docs mode to composed storybooks Feb 4, 2022
@shilman shilman merged commit 9b9ea26 into next Feb 4, 2022
@shilman shilman deleted the fix/ui/composition_docs_mode branch February 4, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants