Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style handling in angular example in monorepo #17343

Merged
merged 2 commits into from Feb 3, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 26, 2022

Issue: N/A

What I did

There was a style flicker in the addon interactions stories, this PR is a simple fix to solve that

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Jan 26, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit bb50807. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf changed the title chore(storybook): improve style handling in angular example Improve style handling in angular example Jan 26, 2022
@yannbf yannbf added the angular label Jan 31, 2022
@yannbf yannbf changed the title Improve style handling in angular example Improve style handling in angular example in monorepo Jan 31, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style is messed up across the stories -- don't merge 😉

@yannbf yannbf force-pushed the chore/improve-styling-angular-example branch 2 times, most recently from e0625b8 to b6a279b Compare February 1, 2022 17:31
@yannbf
Copy link
Member Author

yannbf commented Feb 1, 2022

@shilman I moved some of the styles from bootstrap to the example and got rid of the bootstrap import. It's just for showcasing the form so it's ok to have the styles like that I'd say

@yannbf yannbf force-pushed the chore/improve-styling-angular-example branch from b565adf to d02a5d9 Compare February 2, 2022 14:21
@yannbf yannbf force-pushed the chore/improve-styling-angular-example branch from d02a5d9 to bb50807 Compare February 3, 2022 09:47
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 64f4093 into next Feb 3, 2022
@shilman shilman deleted the chore/improve-styling-angular-example branch February 3, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants