Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add weekly check for broken markdown links #17799

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 25, 2022

Issue: N/A

What I did

With this action we should never have issues where users complain about broken links 🎉

As of the time this PR ran, the repository has a total of 6624 links, of which 138 are broken.

For reference, here's the list of broken links we should fix:
https://github.com/storybookjs/storybook/runs/5726975177?check_suite_focus=true

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Mar 25, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9bc4580. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @yannbf 🙌

@shilman shilman changed the title chore: add weekly check for broken markdown links Build: Add weekly check for broken markdown links Mar 28, 2022
@yannbf
Copy link
Member Author

yannbf commented Mar 28, 2022

@shilman this should be good to go but there's something odd with DangerJS:

error danger@11.0.2: The engine "node" is incompatible with this module. Expected version ">=14.13.1". Got "12.22.11"
  error Found incompatible module.

Did something change recently?

@Pepijnk12
Copy link
Contributor

@shilman this should be good to go but there's something odd with DangerJS:

error danger@11.0.2: The engine "node" is incompatible with this module. Expected version ">=14.13.1". Got "12.22.11"
  error Found incompatible module.

Did something change recently?

Should be fixed #17826

@yannbf
Copy link
Member Author

yannbf commented Mar 31, 2022

@shilman this should be good to go but there's something odd with DangerJS:

error danger@11.0.2: The engine "node" is incompatible with this module. Expected version ">=14.13.1". Got "12.22.11"
  error Found incompatible module.

Did something change recently?

Should be fixed #17826

Thanks a lot @Pepijnk12 ! I'll rerun the steps now

@ndelangen ndelangen merged commit a91b421 into next Mar 31, 2022
@ndelangen ndelangen deleted the ci/markdown-link-check branch March 31, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants