CLI/Vue: add interactions to vue cli template #18021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e69896d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
added
feature request
cli
vue
patch:yes
|
Thanks for your contribution @italoteix! Unfortunately it seems like the Vue rendering engine has some sort of delay which ends up impacting the tests that ran in the play function, so they fail. I'm not sure what to do here |
yannbf
requested changes
Apr 22, 2022
yannbf
reviewed
Apr 22, 2022
…ithub.com/italoteix/storybook into feat/add-interactions-to-vue-cli-template
yannbf
reviewed
Apr 23, 2022
yannbf
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
This PR is good! It surfaces an issue with the vue2 renderer (might be related to how it handles args before rendering stories), but overall the PR is all good! Thanks @italoteix
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16722
What I did
Similar to PR #17345. Added interactions to Vue cli template.
How to test
Build cli locally and run repro to select Vue as a framework
If your answer is yes to any of these, please make sure to include it in your PR.