Core: Fix story index for CSF default exports as TS vars #18054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 28d1832. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
added
bug
patch:yes
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 27, 2022
Core: Fix story index for CSF default exports as TS vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
It was reported that
Button.stories.tsxwas not showing up in the sidebar whenstoryStoreV7was being used.Repro here from @dannyhw https://github.com/dannyhw/ReproStoryStoreV7
What I did
This is an unhandled case in the code. I fixed the code by first checking if the default export is a variable declaration, and then applying the logic to either the declaration itself or the variable that it references.
This will handle the TS "as" case, and whatever other cases come up.
How to test
See attached unit test