Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: Syntax error in vite builder docs #18345

Merged
merged 1 commit into from
May 27, 2022
Merged

documentation: Syntax error in vite builder docs #18345

merged 1 commit into from
May 27, 2022

Conversation

squarism
Copy link
Contributor

Just a missing comma in the example.

Issue:

What I did

Fixed a small syntax error in the docs.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Just a missing comma in the object.
@nx-cloud
Copy link

nx-cloud bot commented May 27, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 100450e.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 27, 2022
@jonniebigodes
Copy link
Contributor

@squarism thanks for the time and effort you've put into this pull request and help us improve the documentation by catching that typo. We appreciate it. Looks good on my end. I'll merge it as soon as the checks clear.

Hope you have a great weekend.

Stay safe

@jonniebigodes jonniebigodes merged commit 44f7a2a into storybookjs:next May 27, 2022
@squarism squarism deleted the patch-1 branch May 27, 2022 22:07
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 3, 2022
shilman pushed a commit that referenced this pull request Jun 3, 2022
documentation: Syntax error in vite builder docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants