Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (Docs) Minor updates to docs and snippets #18378

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

jonniebigodes
Copy link
Contributor

With this pull request the documentation is updated to provide a better UX when a user tries to copy the snippets in our documentation, leading them to copy over unwanted portions of the commands.

Closes #17594

What was done:

  • Updated the sections in the documentation that required the most attention.
  • Added the required snippets.
  • Left out the framework-specific install instructions files and install issues as to avoid adding misconceptions around the commands (npx sb init vs npx storybook init)

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels May 31, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2a3ef9a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes
Copy link
Contributor Author

Self merging this

@jonniebigodes jonniebigodes merged commit 5bacf4d into next Jun 1, 2022
@jonniebigodes jonniebigodes deleted the chore_docs_minor_fixes_snippets branch June 1, 2022 15:12
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 3, 2022
shilman pushed a commit that referenced this pull request Jun 3, 2022
…ppets

Chore: (Docs) Minor updates to docs and snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants