Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global argTypes definition docs #18380

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix global argTypes definition docs #18380

merged 1 commit into from
May 31, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented May 31, 2022

Issue:

What I did

While working on storybookjs/builder-vite#399, I found that the example in the docs for global argTypes was incorrect. So, this updates it so that it works correctly.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented May 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2317e6e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 31, 2022
@jonniebigodes
Copy link
Contributor

@IanVS thanks for the time and effort you've put into this pull request and help us improve the documentation by catching this small but rather important typo. Going to merge it.

Hope you have a great day!

Stay safe

@jonniebigodes jonniebigodes merged commit 01fba57 into next May 31, 2022
@jonniebigodes jonniebigodes deleted the fix-global-arg-docs branch May 31, 2022 22:32
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 3, 2022
shilman pushed a commit that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants