Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update link to Initial Setup section #18411

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

bytrangle
Copy link
Contributor

Issue:

What I did

In the Contribute page, under the Run tests & examples section, there's an internal link to the previous section Initial setup, but the link is incorrect. It points to the section Run tests & examples itself. I just updated it.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 07ca2aa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 6, 2022
@jonniebigodes
Copy link
Contributor

@bytrangle thanks for the time and effort you've put into this pull request and help us improve our documentation by catching that small but rather important typo. Appreciate it. Going to merge this.

Hope you have a great week!

stay safe

@jonniebigodes jonniebigodes merged commit 850e740 into storybookjs:next Jun 6, 2022
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Jun 7, 2022
shilman pushed a commit that referenced this pull request Jun 7, 2022
Docs: Update link to Initial Setup section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants