Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: (Docss) Minor tweaks around SB env vars #18418

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

jonniebigodes
Copy link
Contributor

With this pull request, issue #18082 is closed.

What was done:

  • Updated Env vars docs to include information that vars are built into SB
  • Updated FAQ to reflect that
  • Updated the fields table in the configure/overview

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 6, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 17b8bf4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #18418 (17b8bf4) into next (6b8210b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next   #18418   +/-   ##
=======================================
  Coverage   32.04%   32.04%           
=======================================
  Files         975      975           
  Lines       19216    19216           
  Branches     4031     4031           
=======================================
  Hits         6158     6158           
+ Misses      12495    12494    -1     
- Partials      563      564    +1     
Impacted Files Coverage Δ
addons/a11y/src/components/A11YPanel.tsx 84.09% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8210b...17b8bf4. Read the comment docs.

@jonniebigodes jonniebigodes merged commit c8a3b7b into next Jun 6, 2022
@jonniebigodes jonniebigodes deleted the chore_docs_env_vars_tweaks branch June 6, 2022 20:26
@shilman shilman added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Jun 7, 2022
shilman pushed a commit that referenced this pull request Jun 7, 2022
Chore: (Docss) Minor tweaks around SB env vars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants