Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve link text (whats-a-story doc) #18566

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

minimalsm
Copy link
Contributor

Issue: None

It's good practice to put all necessary context to understand a link within the link's text. This improves UX and accessibility.

What I did

  • Wrap the entire necessary context in the link tags
  • Removed the word also because it is unnecessary/doesn't make sense

@nx-cloud
Copy link

nx-cloud bot commented Jun 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3389237. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 25, 2022
@jonniebigodes
Copy link
Contributor

@minimalsm thanks for this small but rather important pull request and help us improve our documentation to be more inclusive, we appreciate it 🙏 ! I've reviewed and looks good to me. I'm going to merge it once it automated checks finish running.

Hope you have a good weekend.

Stay safe

@jonniebigodes jonniebigodes merged commit b2d8c77 into storybookjs:next Jun 25, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 26, 2022
shilman pushed a commit that referenced this pull request Jul 26, 2022
Improve link text (whats-a-story doc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants