Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of .babelrc in typescript instructions #18649

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jul 7, 2022

Issue:

What I did

This fixes an inaccuracy from #18101, since the babel config will apply to all files, not just config files.

I also added a note about ts-node, even though it has some pitfalls and might not work great for all cases. I think both of these options are short-term until 7.0 is released with better support.

I removed @babel/preset-env from the example babel config, since it's not really useful without being configured, and it has nothing to do with using typescript.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jul 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dd5f380. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 7ca3a53 into next Jul 7, 2022
@ndelangen ndelangen deleted the ts-babel-fixes branch July 7, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants