Mention import.meta.env for vite builder #18650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 97ef0cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
IanVS
changed the title
jonniebigodes
added
the
patch:yes
jonniebigodes
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
@IanVS thanks for taking the time and effort to make this pull request and address the Discord thread, appreciate it 🙏 !
On my end it's all good, going to merge this.
Hope you have a great day.
Stay safe
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jul 26, 2022
Mention import.meta.env for vite builder
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
As discussed in discord, this adds a mention in the documentation that Vite makes environment variables available under
import.meta.envrather thanprocess.env.How to test
If your answer is yes to any of these, please make sure to include it in your PR.