Docs: Fix Typo in list-story-starter.ts-3.ts.mdx #18828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Component Object inferred the wrong Type <typeof LoginForm>. Should be <typeof List> instead :)
darleendenno
approved these changes
Aug 1, 2022
jonniebigodes
added
documentation
patch:yes
|
@JULO01 thanks for taking the time and effort into this pull request and helping us improve our documentation by catching this small but rather important typo. We appreciate it. I've looked at it and it's all good on my end. Going to merge this. |
|
@jonniebigodes Thanks for your reply, I'm happy that i could help :) |
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Aug 2, 2022
Docs: Fix Typo in list-story-starter.ts-3.ts.mdx
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Component Object inferred the wrong Type < typeof LoginForm >. Should be < typeof List > instead :)
Issue:
Component was declared with the woring type in the markdown docs.
What I did
Replace the < typeof LoginForm > with < typeof List >
Everybody: Please submit all PRs to the
nextbranch unless they are specific to the current release. Storybook maintainers cherry-pick bug and documentation fixes into themasterbranch as part of the release process, so you shouldn't need to worry about this. For additional guidance: https://storybook.js.org/docs/react/contribute/how-to-contributeMaintainers: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]-->