Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: (Docs)Adds why page #19136

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Chore: (Docs)Adds why page #19136

merged 1 commit into from
Sep 7, 2022

Conversation

jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Sep 7, 2022 •
edited

With this pull request the documentation is updated to include the Why Storybook page into the documentation

What was done:

  • Updated Toc with the new entry
  • Created snippets for the supported frameworks
  • Created a new folder with the assets for this page for a better organization to avoid leaving them in the root folder of the docs, opening up the possibility for future updates.

Regarding the snippets and to avoid any confusion and better readability, I went with a full example featuring args.

Once this is merged I'll make a follow up pr with the required changes for CSF 3

Feel free to provide feedback.

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Sep 7, 2022
winkerVSbecks
winkerVSbecks approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@winkerVSbecks winkerVSbecks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jonniebigodes
Copy link
Contributor Author

Self-merging this. Thanks for reviewing it @winkerVSbecks

@jonniebigodes jonniebigodes merged commit e76d892 into next Sep 7, 2022
@jonniebigodes jonniebigodes deleted the chore_docs_add_why_page branch September 7, 2022 19:51
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 13, 2022
shilman pushed a commit that referenced this pull request Sep 13, 2022
@jonniebigodes @shilman
Merge pull request #19136 from storybookjs/chore_docs_add_why_page
eb382af 
Chore: (Docs)Adds why page
@dannyhw dannyhw mentioned this pull request Nov 26, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkerVSbecks winkerVSbecks winkerVSbecks approved these changes

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonniebigodes @winkerVSbecks @shilman