Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove angular-cli example #19202

Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 16, 2022

Telescoping on #19181

WIP

  • Move basics, core, legacy and others.
  • Fix TS problems in stories
  • Rename files / remove titles
  • Verify all stories are rendering properly.
    • stories-frameworks-angular-basics-component-with-ng-content-ng-content-about-parent--with-component-and-args -- color is not getting picked up as an "Input" or passed to the component it seems
    • stories-frameworks-angular-basics-component-with-provider-di--inputs-and-inject-dependencies-with-args -- missing elRefStr and isAllDeps "methods".
    • stories-frameworks-angular-core-decorators-theme-decorator-decorators--base relies on theme global/toolbar exported from preview.js -- should we drop this -- or add a general story that checks that globals are available in decorators?
  • Ensure docs stories are reflected in other PRs

What I did

  • Copied initial stories from angular-cli
  • Deleted @ngrx/store story as we can't add a dep

@tmeasday tmeasday marked this pull request as draft September 16, 2022 02:01
@tmeasday tmeasday added maintenance User-facing maintenance tasks angular labels Sep 16, 2022
@tmeasday tmeasday closed this Sep 16, 2022
@tmeasday tmeasday force-pushed the tom/sb-606-migrate-stories-and-delete-angular-cli branch from 2a6a6fe to 90575ba Compare September 16, 2022 05:24
@tmeasday tmeasday reopened this Sep 16, 2022
@tmeasday tmeasday marked this pull request as ready for review October 10, 2022 06:14
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- great work!

@tmeasday
Copy link
Member Author

Merging this into #19181

@tmeasday tmeasday merged commit 4ebdcda into tom/sb-512-angular-14 Oct 10, 2022
@tmeasday tmeasday deleted the tom/sb-606-migrate-stories-and-delete-angular-cli branch October 10, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants