Build: Bundle lib/core-server with ts-up #19278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
approved these changes
Sep 28, 2022
| @@ -1,5 +1,5 @@ | |||
| import { dirname, join } from 'path'; | |||
| import { copy, writeFile, remove } from 'fs-extra'; | |||
There was a problem hiding this comment.
What's happening with all these changes @ndelangen? Does tsup not like named imports in some cases?
There was a problem hiding this comment.
I think what happening is that node now runs in actual ESM mode, or esbuild-register is mimicking that mode more accurately, and fs-extra isn't actually ESM.
| @@ -1,6 +1,8 @@ | |||
| // eslint-disable-next-line @typescript-eslint/triple-slash-reference | |||
| /// <reference path="./typings.d.ts" /> | |||
|
|
|||
| // | |||
There was a problem hiding this comment.
I had a commit that was corrupt on CI 😖 I needed to commit something to kick it into action. Will remove.
Comment on lines
+14
to
+18
| const defaultFavIcon = path.join( | ||
| path.dirname(require.resolve('@storybook/core-server/package.json')), | ||
| 'public', | ||
| 'favicon.ico' | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const defaultFavIcon = path.join( | |
| path.dirname(require.resolve('@storybook/core-server/package.json')), | |
| 'public', | |
| 'favicon.ico' | |
| ); | |
| const defaultFavIcon = path.resolve( | |
| require.resolve('@storybook/core-server/package.json'), './public/favicon.ico') |
|
Converted into draft, this seems to be a very pivotal package, not easy to convert. I might drop this for now, since I need to work on other stuff. |
IanVS
added
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #18732