-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 15 compatibility #19875
Angular 15 compatibility #19875
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,11 +11,7 @@ import { CLIOptions } from '@storybook/types'; | |
import { catchError, map, mapTo, switchMap } from 'rxjs/operators'; | ||
import { sync as findUpSync } from 'find-up'; | ||
import { sync as readUpSync } from 'read-pkg-up'; | ||
import { | ||
BrowserBuilderOptions, | ||
ExtraEntryPoint, | ||
StylePreprocessorOptions, | ||
} from '@angular-devkit/build-angular'; | ||
import { BrowserBuilderOptions, StylePreprocessorOptions } from '@angular-devkit/build-angular'; | ||
|
||
import { buildStaticStandalone } from '@storybook/core-server'; | ||
import { StandaloneOptions } from '../utils/standalone-options'; | ||
|
@@ -27,7 +23,7 @@ export type StorybookBuilderOptions = JsonObject & { | |
tsConfig?: string; | ||
compodoc: boolean; | ||
compodocArgs: string[]; | ||
styles?: ExtraEntryPoint[]; | ||
styles?: BrowserBuilderOptions['styles']; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I think you're on the right track.. in my investigation I also landed on some styles.entry/runtime being the source of the problem. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found that this file:
And the code that was breaking looked like this: /***/ "./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined":
/*!************************************************************************************************!*\
!*** ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=false&noInfo=undefined ***!
\************************************************************************************************/
/***/ ((module, __unused_webpack_exports, __webpack_require__) => {
var __resourceQuery = "?reload=true&quiet=false&noInfo=undefined";
/* module decorator */ module = __webpack_require__.nmd(module);
/*eslint-env browser*/
/*global __resourceQuery __webpack_public_path__*/
var options = {
path: '/__webpack_hmr',
timeout: 20 * 1000,
overlay: true,
reload: false,
log: true,
warn: true,
name: '',
autoConnect: true,
overlayStyles: {},
overlayWarnings: false,
ansiColors: {}
};
if (true) {
var overrides = Object.fromEntries(new URLSearchParams(__resourceQuery.slice(1)));
setOverrides(overrides);
}
if (typeof window === 'undefined') {
// do nothing
} else if (typeof window.EventSource === 'undefined') {
console.warn("webpack-hot-middleware's client requires EventSource to work. " + 'You should include a polyfill if you want to support this browser: ' + 'https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events#Tools');
} else {
if (options.autoConnect) {
connect();
}
} failing on:
This error happened:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
stylePreprocessorOptions?: StylePreprocessorOptions; | ||
} & Pick< | ||
// makes sure the option exists | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works...
I assume we're going to have to think about how to make this backwards compatible?