Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add dark-mode migration docs #20881

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Documentation: Add dark-mode migration docs #20881

merged 4 commits into from
Nov 28, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 2, 2023

No description provided.

yannbf
yannbf requested changes Feb 2, 2023
View reviewed changes
MIGRATION.md Outdated Show resolved Hide resolved
jonniebigodes
jonniebigodes requested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall just a small change is required from my end and this should be good to go. Thanks for putting this together, appreciate it 🙏

MIGRATION.md Outdated Show resolved Hide resolved
@ndelangen ndelangen added the ci:docs Run the CI jobs for documentation checks only. label Nov 28, 2023
@ndelangen ndelangen changed the title Add dark mode migration docs Documentation: Add dark-mode migration docs Nov 28, 2023
@socket-security Socket Security
Copy link

socket-security bot commented Nov 28, 2023 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@ndelangen ndelangen changed the base branch from next to release-8-0 November 28, 2023 11:51
@ndelangen
Copy link
Member

@SocketSecurity ignore vue-hot-reload-api@2.3.4
@SocketSecurity ignore vue-style-loader@4.1.3
@SocketSecurity ignore loupe@2.3.7

JReinhold
JReinhold approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably not be under the "7.0 Webpack" section

@ndelangen ndelangen merged commit 80ffedb into release-8-0 Nov 28, 2023
8 checks passed
@ndelangen ndelangen deleted the shilman/dark-mode-migration branch November 28, 2023 12:43
@ndelangen ndelangen mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf requested changes

@jonniebigodes jonniebigodes jonniebigodes requested changes

@ndelangen ndelangen ndelangen approved these changes

@JReinhold JReinhold JReinhold approved these changes

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

@cdedreuille cdedreuille Awaiting requested review from cdedreuille

@tmeasday tmeasday Awaiting requested review from tmeasday

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

@IanVS IanVS Awaiting requested review from IanVS

@ShaunEvening ShaunEvening Awaiting requested review from ShaunEvening

@kylegach kylegach Awaiting requested review from kylegach

Assignees

@jonniebigodes jonniebigodes

Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shilman @ndelangen @yannbf @JReinhold @jonniebigodes