Fix TS5 support in 6.5 #21745
Fix TS5 support in 6.5 #21745
Conversation
|
Is there any ETA for releasing this? |
|
Update: I was able to advocate for time to upgrade to 7. |
There's been a Storybook breakage with Typescript 5 detailed here: hipstersmoothie/react-docgen-typescript-plugin#78 This fix should allow us to continue using Storybook 6 until we upgrade to Storybook 7 down the road. Even though it relies on an alpha release of 6.5.17-alpha, the only change in the alpha is storybookjs/storybook#21745. It should be an acceptable risk considering that Storybook is internal dev tooling for now.
|
Wanted to leave another comment, as a release for this would be much appreciated but I'm not seeing much traction. For those of us who can't upgrade to Storybook 7 (for me team, we don't use Vite or Webpack so Storybook 7 is unbuildable unless we discard our build tool, Parcel), this is an important v6 release to allow us to keep upgrading our TypeScript version in our repositories. Without this, we are unable to upgrade a variety of libraries we used due to TS being halted at 4.9.3 because of the lack of Storybook v6 support for TS 5+. I'd love to get to Storybook 7 but I'm sure there are many other projects out there in a similar situation where we simply can't make the major version jump (yet). I'm going to try running the alpha release and we'll use that long-term if necessary, but I'm not a big fan of the dependency warnings in the console that (as far as I can tell) are only there because the alpha tag doesn't follow semver so the packages think there is a problem. EDIT: I'm unable to get the alpha release working, but that's only because of the peer dependency not being recognized as valid, even though it's above 6.4.0. When I try to force it, other parts of the dependency tree break. |
Closes #21642
What I did
Upgrade
react-docgen-typescript-pluginto a version that is TS5 compatibleHow to test
Upgrade a React sandbox to TS5 and run Storybook?