Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: change the @next mentions in MIGRATION.md to @latest #21946

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Apr 5, 2023

I noticed the MIGRATION.md file mentions @next a lot. I checked with @shilman and we agreed those references need to be removed.

changes documentation only

@ndelangen ndelangen self-assigned this Apr 5, 2023
@ndelangen ndelangen added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2023
@ndelangen ndelangen changed the title Docs: remove the @next mentions in MIGRATION.md Docs: remove the @next mentions in MIGRATION.md Apr 5, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm @ndelangen I think we need to change @next to @latest whenever we are running via npx. Otherwise it will run the user's installed version.

@ndelangen ndelangen changed the title Docs: remove the @next mentions in MIGRATION.md Docs: change the @next mentions in MIGRATION.md to @latest Apr 5, 2023
@ndelangen ndelangen force-pushed the norbert/remove-at-next-mention-in-migrationmd branch from 8b39c14 to 97085b7 Compare April 5, 2023 11:10
@ndelangen ndelangen requested a review from shilman April 5, 2023 11:10
@ndelangen
Copy link
Member Author

changed @shilman 🤝

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen, all is good on my end. Thanks for putting together this pull request. Appreciate it 🙏 ! Merging

@jonniebigodes jonniebigodes merged commit e9f5b2b into next Apr 5, 2023
18 checks passed
@jonniebigodes jonniebigodes deleted the norbert/remove-at-next-mention-in-migrationmd branch April 5, 2023 12:21
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
…tion-in-migrationmd

Docs: change the `@next` mentions in `MIGRATION.md` to `@latest`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants