-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon Viewport: Add responsive mode #22174
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
Co-authored-by: AndrewLeedham <AndrewLeedham@Outlook.com>
ac66537
to
1bd6919
Compare
I would prefer changing "Responsive" to "Custom" since it functions as a list of sizes and Responsive isn't as clear to me as Custom. |
@yannbf you're considering this a breaking change, can you elaborate? |
Would it be possible to add a feature for responsive viewport resizing, similar to browser dev tools (drag&drop resizing)? This would be a game-changer! Being able to resize the viewport dynamicly (besides fixed sizes like "iPhone 14") is a great way to get a feel of the responsive ui around breakpoints. This would significantly enhance the development experience inside of StoryBook. dev.tools.responsive.layout.mp4 |
Hey @salex97 a feature exactly like that (with the handles) is tough to implement, but this PR does allow you do click and drag the height/width slider like in Figma: |
Just to give a bit clarity on this one, we did a POC during our last hackathon. This feature was located in the addon itself to avoid having to touch directly on the preview. I completely agree that this feature need a more global structure to allow handles on the preview itself. For now I don't believe we have any plan to continue working on it so I'll close this PR. Hopefully we can improve that very soon though. |
Closes #12586
What I did
Brought #12627 back to life!
Note: there might be possible breaking changes here. We gotta test this really well.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]